On 06/21/10 06:41 PM, Keith Mitchell wrote:
Hi all,
I'd like to request a code review for my fixes for the following bugs:
16105 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16105> slim_source
gate could use infrastructure for running unit tests
15229 <http://defect.opensolaris.org/bz/show_bug.cgi?id=15229> .hgignore file
needs updating
The first bug addresses the need to have a "single entry point" for
running (PyUnit) tests within the slim_source gate. When reviewing,
I'd particularly appreciate comments on the README file and its
readability, as well as any comments on general usability in regards
to executing the tests via "slim_test".
The webrev includes an hg bundle file to easily unpack and try out the
tests:
http://cr.opensolaris.org/~kemitche/test_framework/
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Keith,
This is good stuff. Just a couple off issues. I haven't run it yet but
will try later today.
Joe
.hgignore
Issue:
----------
Will .hgignore be stored in our gate? If so shouldn't it have a copyright?
README
I think this looks very good. Just a couple of nits/issues...
Issue:
----------
33 Note: Nose is currently in the JUCR process, and as such
34 may be available from the contrib repository at a
35 later date
Since this statement is date sensitive would it be valuable to put
todays date there?
As of <date> ...
Issue:
----------
37 2) Build the gate, per the instructions in the main README file.
I would suggest putting the gate path to this README as to avoid confusion.
2) Build the gate, per the instructions in<slim_source>/usr/src/README.
Issue:
------
44 3) Use the "bldenv" command to set-up the proper environment variables:
45 /opt/onbld/bin/bldenv -d developer.sh
If step #2 was followed isn't this step unnecessary? I think a comment could
clarify.
Issue:
------
73 To add a set of tests to the suite, update the tests.nose file.
This may need more explanation.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
