Thanks Keith.
LGTM now.
Thanks for the bldenv explanation. I agree with your perspective now.
Thanks!
Joe
On 06/22/10 10:53 AM, Keith Mitchell wrote:
Hi Joe,
Thanks for looking at this! Responses below.
Updated webrevs are available:
http://cr.opensolaris.org/~kemitche/test_framework_v2/
http://cr.opensolaris.org/~kemitche/test_framework_v2.diff/
- Keith
On 06/22/10 03:42 AM, [email protected] wrote:
Keith,
This is good stuff. Just a couple off issues. I haven't run it yet
but will try later today.
Joe
.hgignore
Issue:
----------
Will .hgignore be stored in our gate? If so shouldn't it have a
copyright?
This file is already in our gate, and previously has not had a
copyright notice, so I didn't add one. However, the .hgignore file in
ON does have a copyright, so I'll follow their lead and add a CDDL and
copyright notice.
README
I think this looks very good. Just a couple of nits/issues...
Issue:
----------
33 Note: Nose is currently in the JUCR process, and as such
34 may be available from the contrib repository at a
35 later date
Since this statement is date sensitive would it be valuable to put
todays date there?
As of <date> ...
I'll do that.
Issue:
----------
37 2) Build the gate, per the instructions in the main README file.
I would suggest putting the gate path to this README as to avoid
confusion.
2) Build the gate, per the instructions in<slim_source>/usr/src/README.
Good point, I'll update accordingly.
Issue:
------
44 3) Use the "bldenv" command to set-up the proper environment
variables:
45 /opt/onbld/bin/bldenv -d developer.sh
If step #2 was followed isn't this step unnecessary? I think a
comment could clarify.
bldenv spawns an interactive sub-shell with environment variables set
based off of the supplied developer.sh, whereas if one has run
"nightly", the environment variables are set in the 'nightly' process,
but of course won't get set in the parent process. So for those
developers that generally build the gate by using bldenv and then
running "make install," the step is unnecessary; but as many of us
default to using nightly, this extra step is required.
While I could add explanations to a number of these steps, I'd like to
keep the README focused on the "what" rather than the "why."
Issue:
------
73 To add a set of tests to the suite, update the tests.nose file.
This may need more explanation.
Indeed it would. The explanation is in the tests.nose file; I'd meant
to mention that here.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
