On 06/22/10 15:08, Keith Mitchell wrote:
On 06/22/10 10:53 AM, Sue Sohn wrote:
On 06/21/10 15:41, Keith Mitchell wrote:
Hi all,
I'd like to request a code review for my fixes for the following bugs:
16105 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16105>
slim_source gate could use infrastructure for running unit tests
15229 <http://defect.opensolaris.org/bz/show_bug.cgi?id=15229>
.hgignore file needs updating
The first bug addresses the need to have a "single entry point" for
running (PyUnit) tests within the slim_source gate. When reviewing,
I'd particularly appreciate comments on the README file and its
readability, as well as any comments on general usability in regards
to executing the tests via "slim_test".
The webrev includes an hg bundle file to easily unpack and try out
the tests:
http://cr.opensolaris.org/~kemitche/test_framework/
Thanks,
Keith
------------------------------------------------------------------------
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Keith,
I had a couple of the same comments as Joe, but you've already
addressed them in the updated webrev. In addition,
README:
47 - it would be helpful to mention cd'ing to tools/test (assuming
current directory was usr/src from step 3)
I'll update step 2 to:
/opt/onbld/bin/bldenv -d ../../developer.sh
I noticed that slim_test exits cryptically if this command isn't run, so
I've updated it to check that the required environment is set.
55 - is there a way to specify multiple tests, such as 5,10,17?
Similarly, is there a way to specify a range of tests, say 9-12? If
so, would be good to add that information.
Yes, the syntax is:
slim_test -c tests.nose 1 2 3 [...]
I'll update the README.
I tried running the tests. The installadm_common tests failed, sent
you the trace offline.
For some reason, one of the Python modules I had installed on my system
made it such that the gettext portions of that doctest weren't needed.
However, as the module that caused it isn't particularly relevant here,
I'll revert the related lines in installadm_common.py and make it work
again.
Also, when I run the tests with --with-cover, I get the message:
nose.plugins.cover: ERROR: Coverage not available: unable to import
coverage module
Seems like something might be missing in the README instructions.
I updated the README to indicate that the coverage module needs to be
installed explicitly. I also followed the steps in usr/src/README and
usr/src/tools/tests/README on a clean installation of OpenSolaris in
VirtualBox and verified that there were no other missing dependencies.
Thanks for the work to get this set up!
You're welcome! An updated webrev is available:
http://cr.opensolaris.org/~kemitche/test_framework_v3/
http://cr.opensolaris.org/~kemitche/test_framework_v3.diff/
Works now. Just one little wording suggestion in the README I didn't notice the
first time:
To query the test numbers without re-running the tests
->
To query the test numbers without executing the tests
Otherwise, looks good.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
