Dave,

Thanks for the review :


On 06/15/10 05:06 PM, Dave Miner wrote:
Overall a pretty complete spec.  A few items:

3.2.1.1 - Section could use some reformatting, as there are bullets shown as parallel that are actually sub-bullets of a previous one. Consider using some numbering here, maybe.

Yep, noticed this after I had sent out document, corrected now.

3.2.2.1 - What impact does this have on validation of the new elements introduced here?


Xmllint will do the required relaxng syntax checking, any other validation required will be done within auto_install client code itself, manually.

Do you think I should be adding validation values in here ? as according to Ethan this file is being obsoleted, and I'd like to limit the amount of throw away code written.

3.2.2.4 (last bullet on page 15) - This phrasing is confusing: "Pool name does not exist. If pool name is specified in manifest, then this pool will be overwritten." I'm not sure what to expect - will an existing, named pool be overwritten automatically?


Yes, if the the manifest contains a user specified pool name of "my_new_pool", and this pool already exists on the target being installed to then this pool will be overwritten.


cheers

Matt

Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to