Hi Jan,
Like Joe, I couldn't find very much wrong with these changes.
Nevertheless, I can always nit at something and I've got a few questions
as well.
install-finish:
Based on the webrev and bug comments, I don't quite understand the
strategy going forward. It looks like for liveCD and Text Install, the
SC profile is copied over; for AI no keyboard setting is done - does
this mean that on first boot after an AI install, the user is prompted
for keyboard choice? Or is the setting applied elsewhere?
ict.py:keyboard_layout():
The method for applying the sc_profile does not seem extensible in this
fashion. What happens if, before ICTs are removed as such, we need to
apply a different sc_profile change? I suggest a different approach -
during ICT.__init__, read the sc_template in (either as an lxml.etree or
a plain string). Modify the in-memory representation during ICT
execution, and then write the file to the destination after all ICTs
have completed (as a separate ICT function perhaps). The following XPath
expression would get the appropriate location here, assuming the
lxml.etree route:
layout_element =
sc_template_etree_object.xpath("//servi...@name='system/keymap']/instan...@name='default']/property_gro...@name='keymap']/propv...@name='layout']")[0]
#xpath returns a list, but there should only be one default instance
layout_element.set("value", layout)
Using etree/Xpath also means that the results will be more consistent -
consider what would happen if the sc_template had a second "US-English"
string somewhere in it. The parameter to the Xpath call can, of course,
be statically defined somewhere.
1309-1311:
Would it be simpler to just set /etc/svc/profile/site.xml as the
destination in the first place?
- Keith
On 06/25/10 01:45 AM, Jan Damborsky wrote:
Hi,
could I please get a review of the changes for:
15678 /etc/default/kbd is to be obsoleted by 6944480, installers need
to be accommodated
Webrev:
http://cr.opensolaris.org/~dambi/bug-15678
For reference, here are related ON changes
(they are being reviewed separately):
http://cr.opensolaris.org/~dambi/bug-6944480/
related PSARC:
http://arc.opensolaris.org/caselog/PSARC/2010/183/
From high level point of view, this changes might be
considered as a proof of concept [*] demonstrating approach
we are going to follow in realm of interactive System Configuration.
As far as integration is concerned, the synchronized push
of ON and install changes is scheduled for build 145.
Please provide your comments before COB Friday 7/2.
I plan to address all comments en-bloc after I am back from
vacation in a week of 7/5 - 7/9.
Thank you very much,
Jan
Tests accomplished
------------------
Following images were built using modified Distro Constructor:
x86: AI, LiveCD, text install
Sparc: AI, text install
Installation was done using built images.
It was verified that on installed system, keyboard
layout was correctly configured.
Notes
-----
* Yes, XSLT will be used as a final solution for generating
resulting SC profiles when switching to DOC paradigm ;-)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
