Hi Jan,
Thank you for the reply.
I'm OK with how things are now.
Joe
On 07/ 8/10 04:13 AM, Jan Damborsky wrote:
Hi Joe,
thank you very much for review !
Please see my response in line.
Jan
On 06/28/10 11:41 PM, [email protected] wrote:
On 06/25/10 04:45 AM, Jan Damborsky wrote:
Hi,
could I please get a review of the changes for:
15678 /etc/default/kbd is to be obsoleted by 6944480, installers
need to be accommodated
Webrev:
http://cr.opensolaris.org/~dambi/bug-15678
For reference, here are related ON changes
(they are being reviewed separately):
http://cr.opensolaris.org/~dambi/bug-6944480/
related PSARC:
http://arc.opensolaris.org/caselog/PSARC/2010/183/
From high level point of view, this changes might be
considered as a proof of concept [*] demonstrating approach
we are going to follow in realm of interactive System Configuration.
As far as integration is concerned, the synchronized push
of ON and install changes is scheduled for build 145.
Please provide your comments before COB Friday 7/2.
I plan to address all comments en-bloc after I am back from
vacation in a week of 7/5 - 7/9.
Thank you very much,
Jan
Tests accomplished
------------------
Following images were built using modified Distro Constructor:
x86: AI, LiveCD, text install
Sparc: AI, text install
Installation was done using built images.
It was verified that on installed system, keyboard
layout was correctly configured.
Notes
-----
* Yes, XSLT will be used as a final solution for generating
resulting SC profiles when switching to DOC paradigm ;-)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Jan,
This looks real good. I struggled to find issues! ;)
Thank you :-)
I'll be out on vacation next week. I trust you to do the correct
thing with my input if you need to push before I get back.
I believe we will have time to close the loop after you return,
since we are currently targeting build 145.
[...]
---
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/cmd/gui-install/src/orchestrator-wrappers.c 79 lines changed:
English suggestion:
--------------------
From:
87 /* Since could be also linux swap, check content type */
To:
87 /* Since this could also be a linux swap, check content type */
Changed.
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/cmd/slim-install/finish/install-finish 4 lines changed:
Issue:
------
233 SA.append(ICTO.keyboard_layout())
Did you miss removing this one?
No, this ICT task takes care of generating SC profile configuring
keyboard layout for interactive installers.
In case of AI, SC profile equals to SC manifest - it is directly
copied to the target by recently introduced apply_sysconfig_profile()
ICT task.
Also, based on Keith feedback, keyboard_layout() has been renamed to
generate_sc_profile() to better reflect its new purpose.
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/cmd/slim-install/svc/media-fs-root 8 lines changed:
Question:
---------
252 /usr/bin/kbd -s US-English
When livessh mode why invoke /usr/bin/kbd, won't the default value
for the svc:/system/keymap:default SMF service be English?
No, for interactive installers, keymap/layout property is 'unconfigured'
during DC build (see changes in slimcd_live.xml and text_live.xml).
It assures that keyboard layout chosen by user does not get
overwritten later during boot by keymap SMF service.
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
MISSED 3 Changes to: usr/src/lib/libict/ict_api.h
1.
ICT_SET_KEYBRD_FAIL can be removed from enum: ict_status_t
2.
This #define can be removed:
#define ICT_SET_KEYBRD_FAIL_STR "ICT - Failed to set the keyboard
layout"
3.
This can be be removed from ICT_STR_ERR macro:
(err) == ICT_SET_KEYBRD_FAIL ? ICT_SET_KEYBRD_FAIL_STR : \
Thank you for catching this - I removed that code.
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/liborchestrator/orchestrator_api.h 30 lines changed:
Looks OK. I checked the source pool to see if anything else uses
the symbols you're removing... and couldn't find any.
+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
usr/src/lib/liborchestrator/orchestrator_private.h 7 lines changed:
Looks OK. I checked the source pool to see if anything else uses
the symbols you're removing... and couldn't find any.
Thank you for looking into this !
I have updated webrev with all code review comments,
merged with latest changes in slim_source gate and included also fix
for bug 4585 (fix only modifies default AI manifest),
since we now have necessary infrastructure for configuring SMF
services via SC manifest in place.
Updated webrev is available at
http://cr.opensolaris.org/~dambi/bug-15678-4585/
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
