Hi Ethan,
thank you very much for review.
Please see my response in line.
Jan
On 07/ 3/10 03:07 AM, Ethan Quach wrote:
Jan,
Just a couple of comments...
Makefile.master
---------------------------
108 - Can you move this down a few lines and reuse
$(ROOTUSRSHARE) that is already defined at 111.
Done.
I have updated the webrev accordingly:
http://cr.opensolaris.org/~dambi/bug-15678-4585/
Since support for SMF based SC profile has been delivered,
I enhanced scope of these changes and the webrev now contains
also fix for bug
4585 Automated Installer needs support for setting keyboard layout from
AI manifest
It is basically about enhancing default AI manifest with
default configuration for keymap SMF service.
ict.py:
---------
1361,1363,1365 (line numbers from old file) - curious, why the
removal of these?
This is done as part of general cleanup work - please see below for
reasoning.
Since those changes were part of fix for bug 15723 integrated
earlier today, updated webrev now only removes sysidkbd from list of
sysid applications.
/lib/svc/method/sshd
--------------------
Since start method ofsvc:/network/ssh:default was enhanced to automatically
generate ssh keys in case they don't exist, we no longer need to take care
of this task explicitly:
...
'start')
#
# If host keys don't exist when the service is started, create
# them; sysidconfig is not run in every situation (such as on
# the install media).
#
create_key $SSHDIR/ssh_host_rsa_key rsa
create_key $SSHDIR/ssh_host_dsa_key dsa
/usr/lib/ssh/sshd
;;
...
See also bug 15618.
/usr/lib/cc-ccr/bin/eraseCCRRepository,
/usr/lib/scn/bin/cleanup-scn-base
---------------------------------
Those two applications no longer exist on installed system:
$ cat /var/log/sysidconfig.log
Executing Configuration Applications at: Fri Apr 03 00:26:28 2009
Executing config app: /lib/svc/method/sshd
Executing config app: /usr/sbin/sysidkbd
Executing config app: /usr/lib/cc-ccr/bin/eraseCCRRepository
/usr/sbin/sysidconfig: Warning: Application Not Found
Executing config app: /usr/sbin/sysidpm
Executing config app: /usr/lib/scn/bin/cleanup-scn-base
/usr/sbin/sysidconfig: Warning: Application Not Found
Executing config app: /lib/svc/method/net-nwam
Completed Executing Configuration Applications at: Fri Apr 03 00:26:30 2009
Those applications were delivered by SUNWccccr and SUNWscn-base which were
obsoleted:
$ pkg info -r SUNWccccr
Name: SUNWccccr
Summary:
State: Not installed (Obsolete)
Publisher: opensolaris.org
Version: 0.5.11
Build Release: 5.11
Branch: 0.130
Packaging Date: December 18, 2009 10:40:01 PM
Size: 0.00 B
FMRI:
pkg://opensolaris.org/[email protected],5.11-0.130:20091218T224001Z
$ pkg info -r SUNWscn-base
Name: SUNWscn-base
Summary:
State: Not installed (Obsolete)
Publisher: opensolaris.org
Version: 0.5.11
Build Release: 5.11
Branch: 0.130
Packaging Date: December 19, 2009 03:34:16 AM
Size: 0.00 B
FMRI:
pkg://opensolaris.org/[email protected],5.11-0.130:20091219T033416Z
thanks,
-ethan
On 06/25/10 01:45, Jan Damborsky wrote:
Hi,
could I please get a review of the changes for:
15678 /etc/default/kbd is to be obsoleted by 6944480, installers need
to be accommodated
Webrev:
http://cr.opensolaris.org/~dambi/bug-15678
For reference, here are related ON changes
(they are being reviewed separately):
http://cr.opensolaris.org/~dambi/bug-6944480/
related PSARC:
http://arc.opensolaris.org/caselog/PSARC/2010/183/
From high level point of view, this changes might be
considered as a proof of concept [*] demonstrating approach
we are going to follow in realm of interactive System Configuration.
As far as integration is concerned, the synchronized push
of ON and install changes is scheduled for build 145.
Please provide your comments before COB Friday 7/2.
I plan to address all comments en-bloc after I am back from
vacation in a week of 7/5 - 7/9.
Thank you very much,
Jan
Tests accomplished
------------------
Following images were built using modified Distro Constructor:
x86: AI, LiveCD, text install
Sparc: AI, text install
Installation was done using built images.
It was verified that on installed system, keyboard
layout was correctly configured.
Notes
-----
* Yes, XSLT will be used as a final solution for generating
resulting SC profiles when switching to DOC paradigm ;-)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
