On 08/10/10 05:30 PM, Sarah Jelinek wrote:
Hi Keith,
Thank you for the review. There are some files you reviewed that I
modified so I am addressing your comments for those..
ai_manifest.xml:
37: Comment says two mutually exclusive groups, but three are listed.
Please clarify.
It is three. I will update.
153-160: Perhaps I missed this file when I did my changes earlier,
but for consistency with our other manifest files, the packages
should be pre-pended with "pkg:/" (e.g. pkg:/SUNWcs). I also believe
with bug 1637 fixed, SUNWcs & SUNWcsd are no longer required and
should be removed.
I will fix the pkg:/ naming issue. We currently have SUNWcs and csd in
the default.xml manifest. I looked at the bug you referred to and see
where the mention of having to add SUNWcs and SUNWcsd must be
installed before installing any packages with user or group actions. I
don't see where this fix removed the need for these packages.
They should be picked up via dependencies (slim_install depends on some
pkgs some/all of which depend on SUNWcs/d). Since they don't need to be
installed separately and first, there's no real need to explicitly list
them.
179-180: Comment seems out of date.
Will remove.
189: Extraneous (or missing) quote.
Fixed.
194: Update comment.
Fixed.
223: Should this line be outside the comment block that ends on line
224, as it was previously?
This was outside the comment block but that was because they specified
it this way:
<searchall/>
As if it was empty. And, since the initial part of it was within a
comment it validated ok.
The new example shows the full search_all and add_drivers so I think
it is ok to keep it within this comment as is.
Ok, thanks for clarifying.
- Keith
auto-install/default.xml:
35-41: See prior comment on pkg names.
Will fix.
software.dtd:
55: im_type - for curiosity's sake, is there a reason this isn't
"img_type"?
No, no reason. I could change this. Dermot, if I make this change does
it mean we have to change anything in the AI client code? We don't use
this for these changes do we?
thanks,
sarah
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
