Hi Glenn,
I don't see usr/src/Targetdirs. Should line 67 be removed?
Also:
usr/src/lib/Makefile
usr/src/lib/libtd/Makefile
usr/src/lib/libti/Makefile
--> Copyright should be 2007, 2010
usr/src/man/Makefile
--> Copyright should be 2008, 2010
I didn't really review the flag day since it's preliminary, but you might want
to fix:
smoother if you're existing BE -> smoother if your existing BE
Thanks,
Sue
On 08/17/10 13:31, Glenn Lagasse wrote:
Hi All,
I need to get a couple of pairs of eyes to look at this code review I
have for 16813. This is in support of the beadm/libbe migration from
slim_source into ON. This code review incorporates the changes I asked
for review of last week. Some additional investigation and testing
found some issues with my idea to integrate minimal changes into
slim_source for build 147 that made that idea untenable. So, we're
going to have to have a major flag day once I integrate this changeset
for build 147. I've attached a preliminary copy of the flag day
instructions (it's very rough, I'll be fleshing it out considerably but
wanted to put it out there so people could get an idea of what will be
involved).
I've done some basic testing with this changeset (and associated flag
day). I've verified that once you comply with the flag day, building
slim_source generates packages with proper dependencies. I'll be doing
more testing before integration. As I need to integrate this for 147,
I'd like to get this review done by COB tomorrow (Wednesday). There
really isn't a lot to review since I'm mostly removing source files.
Defect:
https://defect.opensolaris.org/bz/show_bug.cgi?id=16813
Webrev:
http://cr.opensolaris.org/~glagasse/slim_post_ON_int/
Thanks,
Glenn
------------------------------------------------------------------------
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
