Hi Glenn.
Looks like you already addressed usr/src/Targetdirs, which was my only
"code" question. About the flag day...
You may want to mention specifically what the flag day is for. There
are numbered instructions at the top, but what do they accomplish, for
example?
Maybe it's obvious, but you may want to mention that until slim_source
goes away, the systems building it need to be running the same build of
ON as what they are building (or at least have the most up-to-date
/usr/include/libbe.h and /usr/include/libbe_priv.h on their build system).
The rest looks OK to me.
Thanks,
Jack
On 08/17/10 13:31, Glenn Lagasse wrote:
Hi All,
I need to get a couple of pairs of eyes to look at this code review I
have for 16813. This is in support of the beadm/libbe migration from
slim_source into ON. This code review incorporates the changes I asked
for review of last week. Some additional investigation and testing
found some issues with my idea to integrate minimal changes into
slim_source for build 147 that made that idea untenable. So, we're
going to have to have a major flag day once I integrate this changeset
for build 147. I've attached a preliminary copy of the flag day
instructions (it's very rough, I'll be fleshing it out considerably but
wanted to put it out there so people could get an idea of what will be
involved).
I've done some basic testing with this changeset (and associated flag
day). I've verified that once you comply with the flag day, building
slim_source generates packages with proper dependencies. I'll be doing
more testing before integration. As I need to integrate this for 147,
I'd like to get this review done by COB tomorrow (Wednesday). There
really isn't a lot to review since I'm mostly removing source files.
Defect:
https://defect.opensolaris.org/bz/show_bug.cgi?id=16813
Webrev:
http://cr.opensolaris.org/~glagasse/slim_post_ON_int/
Thanks,
Glenn
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
