Hi Sue, On 09/ 8/10 08:35 PM, Sue Sohn wrote: > Hi Darren, > > This is good to know about - thanks for pointing it out. I will make changes > to > use os.sysconf for logname and password max.
Ok. > > I am a bit uncomfortable about hardcoding the 735 to get the max hostname. > Though maybe unlikely to change, the define still could change. I am leaning > towards leaving that particular MAX as 255. If the maximum hostname length > ever > increases (I doubt it will ever decrease), then the result would be that the > text installer would need to change before accepting the larger length. > Whereas > if the define were to change, then there could be a less desirable result. I agree, I wasn't that happy with it either - but I don't expect it to change too much given it's a POSIX value. For now I think what you are doing is fine, but might be useful to have a comment near it about the sysconf value... One other question I suppose, but it may be out of scope of this change, is whether these MAX type values are really something that the installer applications themselves should be defining, or should we have a more common location for such values to be pulled from e.g. from the ICT or configuration module where the information is fed to. Thanks Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
