Hi Sue, Sorry I couldn't have time to look at the webrev enough.
Regarding isinstance(basestring) inserted in textwidth(), you found some case that instance of other class or list can be passed? In that case, raising error (TypeError?) or considering to enhance the function if expectation of the caller is reasonable. Regarding other parts, if the horizontal scroll is used by field which accept multicolumn characters, I might want to confirm if the scroll is taking care to avoid splitting a character between viewable and hidden areas. However, it looks that there's no such field and this installer is not likely to have, right? In that case this topic could have lower prioirity. Thanks, Takeshi On 2010年09月09日 01:12, Sue Sohn wrote:
Could I please get a review of the changes for: 15166 Text Installer EditFields need to support horizontal scrolling Webrev: http://cr.opensolaris.org/~sohn/15166 Thanks, Sue
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
