On 09/09/10 08:44, Takeshi Asano wrote:
Hi Sue,
Sorry I couldn't have time to look at the webrev enough.
Regarding isinstance(basestring) inserted in textwidth(),
you found some case that instance of other class or list can be
passed? In that case, raising error (TypeError?) or considering
to enhance the function if expectation of the caller is reasonable.
The text in edit_field is stored as a list, so this check was needed to avoid
throwing an exception.
Regarding other parts, if the horizontal scroll is used
by field which accept multicolumn characters, I might
want to confirm if the scroll is taking care to avoid
splitting a character between viewable and hidden areas.
However, it looks that there's no such field and this installer
is not likely to have, right?
The fields using horizontal scroll are the hostname, real user name, and all
password fields. Passwords won't be an issue since they use asterisks, and
hostname is currently restricted to ascii and numbers (though that could change
in the future). The real user name might contain multicolumn characters though.
I will contact you offline to coordinate testing this.
Thanks,
Sue
In that case this topic could have lower prioirity.
Thanks,
Takeshi
On 2010年09月09日 01:12, Sue Sohn wrote:
Could I please get a review of the changes for:
15166 Text Installer EditFields need to support horizontal scrolling
Webrev:
http://cr.opensolaris.org/~sohn/15166
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
