On 09/10/10 04:51 PM, Dave Miner wrote:
On 09/10/10 10:32 AM, Jan Damborsky wrote:
On 09/10/10 04:21 PM, Dave Miner wrote:
On 09/10/10 09:15 AM, Jan Damborsky wrote:
On 09/10/10 10:00 AM, Frank Allan wrote:
Thanks Jan

I guess I am just getting old and missing small (but vital) details.
:-[

Maybe we should consider putting slightly different thing in that sample
manfiest :-)
For instance 'xxx/v4' instead of 'net0/v4'. That might have it more
obvious that this
is parameter which is also expected to be modified.


Well, for now it might be mildly helpful, but once
vanity-naming-by-default happens, that example would, I believe, work
out of the box.

This is a good point.

Perhaps just a comment in the example would be sufficient?

I agree. We plan to introduce comment sections in SC default manifest
and templates in similar way we currently do in other manifests.
We can't do this right now, since when embedded within AI manifest, SC
manifest
is put there as XML comment and XML does not cope with nested comments.


Yes :-) However, since static_network.xml is set up as a separate document that has to be edited in, it seems we could add the comment and say that as well.

That sounds reasonable. I will file bug for this.

I'd think it would fail validation on add if the comment wasn't edited out, wouldn't it?

Yes, it would. Attempt to add such manifest failed in following way:

# installadm add-manifest -n s-147-wo-dcfs -m /tmp/default.xml
Error: AI manifest failed validation:
Comment not terminated
<!-- <?xml version='1.0'?>
<!DOCTYPE service_bun
Opening and ending tag mismatch: sc_embedded_manifest line 90 and service
Opening and ending tag mismatch: ai_instance line 27 and service_bundle
Opening and ending tag mismatch: auto_install line 26 and sc_embedded_manifest
Extra content at the end of the document
#

Thank you,
Jan

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to