I hate replying to myself, but I wanted to clarify some things...
On 09/20/10 09:40 AM, Keith Mitchell wrote:
Hi Jan,
The comments in the manifest file indicate that only "dcfs" and "none"
are valid, but the RNG file indicates that 'gzip' is still ok.
I'm just curious if this was intended or not.
boot_archive_archive.py:
The checks at 136-137 seem redundant with the checks at 173.
Out of curiosity, what's the reasoning behind prepending everything
with "./" and then stripping out that same "./" on line 168?
168: This lstrip will cause problems with files that start with ".":
>>> "./.hidden_file".lstrip("./")
'hidden_file'
I meant to add that I *think* that "os.path.relpath(filename.strip())"
will do what you want:
>>> os.path.join(".", ".hidden_file")
'./.hidden_file'
>>> os.path.relpath("./.hidden_file")
'.hidden_file'
It may be worth considering whether use of other os.path functions is
appropriate/necessary for some of the other changes here, such as
os.path.join and os.path.normpath.
- Keith
On 09/20/10 08:53 AM, Jan Damborsky wrote:
Hello,
could I please get a code review for fix for following bug:
6984618 Not preserving hard links in boot archive during
fiocompression affects Sparc text media
webrev is available at:
http://cr.opensolaris.org/~dambi/bug-6984618/
Thank you,
Jan
tests accomplished:
[1] Sparc AI
* AI Sparc image based on 148 was built with DC containing the fix
* using that image, build 148 was installed
[2] Sparc text installer
* Text Sparc image based on 147 was built with DC containing the fix
* using that image, build 147 was installed
* resulting system was updated via pkg image-update to build 148
[3] regression tests
* x86 LiveCD image based on 148 was built with DC containing the fix
* using that image, build 148 was installed in Virtual Box guest
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
