Hi Sue,
thank you for looking at those changes.
I have incorporated all your comments and updated the webrev accordingly:
http://cr.opensolaris.org/~dambi/bug-6984618-cr/
Jan
On 09/20/10 08:56 PM, Sue Sohn wrote:
On 09/20/10 08:53, Jan Damborsky wrote:
Hello,
could I please get a code review for fix for following bug:
6984618 Not preserving hard links in boot archive during
fiocompression affects Sparc text media
webrev is available at:
http://cr.opensolaris.org/~dambi/bug-6984618/
Thank you,
Jan
tests accomplished:
[1] Sparc AI
* AI Sparc image based on 148 was built with DC containing the fix
* using that image, build 148 was installed
[2] Sparc text installer
* Text Sparc image based on 147 was built with DC containing the fix
* using that image, build 147 was installed
* resulting system was updated via pkg image-update to build 148
[3] regression tests
* x86 LiveCD image based on 148 was built with DC containing the fix
* using that image, build 148 was installed in Virtual Box guest
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
In addition to Keith's comments, a couple of nits:
boot_archive_archive.py
160 (nit)
meet following -> meet all of the following
471 Your exception error message needs a space after "archive"
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
