Hi Jan,
I got the following questions and comments on the
boot_archive_archive.py file.
1) The fix you have for the bug seem kinda complicated and involve a lot
of new code.
Is there any problem with the following approach:
a) Move the cpio related stuff from lines 437-448 (of the old
boot_archive_archive.py file)
into a function.
b) For x86 and uncompress sparc case, call that function.
c) For sparc and dcfs compress case, call the old "compress()" function.
d) Change the old compress() function to check for hard links, and skip
the compression for those that have hard links. So, just one additional
check in line 109 of the old file.
This seem to make the changes less invasive. Also, it is probably more
efficient
since we are not doing many find() calls to generate large lists and
having to compute
the difference between those lists.
2) lines 108-109, 123-125: I think you are pre-pending "./" to all the
files so you can call "find()"
to expand the uncompressed list. Is the check to see whether the file
name start with './'
necessary? Is it every a case that people are allowed to specify a
relative path in either
the DC manifest or the filelist.ramdisk?
3) line 346-348: compression level always need to be specified. For SPARC,
if they don't want compression, I think users should be required
to specify the string "none" in the manifest. That's what they are
required to do
for x86.
Thanks,
--Karen
On 09/20/10 08:53, Jan Damborsky wrote:
Hello,
could I please get a code review for fix for following bug:
6984618 Not preserving hard links in boot archive during
fiocompression affects Sparc text media
webrev is available at:
http://cr.opensolaris.org/~dambi/bug-6984618/
Thank you,
Jan
tests accomplished:
[1] Sparc AI
* AI Sparc image based on 148 was built with DC containing the fix
* using that image, build 148 was installed
[2] Sparc text installer
* Text Sparc image based on 147 was built with DC containing the fix
* using that image, build 147 was installed
* resulting system was updated via pkg image-update to build 148
[3] regression tests
* x86 LiveCD image based on 148 was built with DC containing the fix
* using that image, build 148 was installed in Virtual Box guest
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
