Hi Ginnie,
I'd like to raise a point w.r.t. the handling of the DataObject class
registration for the XML handling.
You have the classes in the module solaris_install.transfer.info to handle the
<software> tags and sub-tags.
Following on from the recent e-mails on the CUD/DC threads, I think that the
registration of these classes with the DataObjectCache should be done as part of
the __init__.py file, e.g.
in install_transfer/__init__.py add the lines:
import solaris_install.transfer.info
from solaris_install.data_object.cache import DataObjectCache
...
DataObjectCache.register_classes(solaris_install.transfer.info)
(Note this is using the fix for 6996768 that I just sent for CR).
Thanks,
Darren.
On 11/ 3/10 12:58 AM, Ginnie Wray wrote:
> I've incorporate the code review comments from the first round of
> code reviews and would like follow up feedback. The code is posted at:
>
> http://cr.opensolaris.org/~ginnie/transfer/
>
>
> I've posted the diffs from the first code review, so I would like
> to clarify: Keith suggested changing the names of the files from
> transfer_*.py to just *.py, which I've done. That, however, made it
> difficult to post the diffs from the original transfer_*.py files.
> What I've done is included the new file names, and then also posted
> the diffs from the old files. So, there is no need to review any of
> the files marked as new. They are identical to the transfer_*.py file.
>
> My thought was that it would make it a little easier to review the diffs.
>
> Let me know if you have any questions or comments. I would like to push
> on Nov. 16th, so if I could get feedback by the end of the week, I would
> appreciate it.
>
> thanks,
> ginnie
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
