Hi Jean -
Thanks for reviewing.
ginnie
On 11/03/10 09:47, jean.mccormack wrote:
svr4.py:
line 80 : Don't use is
I can't believe I missed it. They are so evil. :)
line 157: I don't think cancel takes timeout anymore.
Ok. I didn't think so, but wasn't sure.
ips.py:
line 76: I think we need to change this to the external URL
yes. I should have done that. It's on my list of final things to do.
line 197: Do you want to try/except around this for version skew as done
in get_ips_api_inst?
ok.
line 305: Please put a space at the end of the string.
line 325: ditto
ok
line 667: Should this line be deleted?
yes.
line 747& 748: Can this be one name?
cpio.py:
line 172 & 173: Do we need both lines?
No. I removed the superfluous entry.
Jean
On 11/ 2/10 06:58 PM, Ginnie Wray wrote:
I've incorporate the code review comments from the first round of
code reviews and would like follow up feedback. The code is posted at:
http://cr.opensolaris.org/~ginnie/transfer/
I've posted the diffs from the first code review, so I would like
to clarify: Keith suggested changing the names of the files from
transfer_*.py to just *.py, which I've done. That, however, made it
difficult to post the diffs from the original transfer_*.py files.
What I've done is included the new file names, and then also posted
the diffs from the old files. So, there is no need to review any of
the files marked as new. They are identical to the transfer_*.py file.
My thought was that it would make it a little easier to review the diffs.
Let me know if you have any questions or comments. I would like to
push on Nov. 16th, so if I could get feedback by the end of the week,
I would appreciate it.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
