Hi Sue -
I removed a couple of commented out lines that I had missed and forgot
to change it in both the "new" and the old. That's the source of the
discrepancy.
I've fixed them so that they are now the same. I checked all of the
files to make sure there aren't any others.
Thanks for catching that.
Here is the updated webrev:
http://cr.opensolaris.org/~ginnie/transfer2/usr/src/lib/install_transfer/transfer_cpio.py.html
For anyone who has looked at the first one I sent out, the only
difference is a couple of comments were removed. There is no difference
in the code content.
thanks,
ginnie
On 11/03/10 10:41, Sue Sohn wrote:
On 11/ 2/10 05:58 PM, Ginnie Wray wrote:
I've incorporate the code review comments from the first round of
code reviews and would like follow up feedback. The code is posted at:
http://cr.opensolaris.org/~ginnie/transfer/
I've posted the diffs from the first code review, so I would like
to clarify: Keith suggested changing the names of the files from
transfer_*.py to just *.py, which I've done. That, however, made it
difficult to post the diffs from the original transfer_*.py files.
What I've done is included the new file names, and then also posted
the diffs from the old files. So, there is no need to review any of
the files marked as new. They are identical to the transfer_*.py file.
My thought was that it would make it a little easier to review the diffs.
Let me know if you have any questions or comments. I would like to
push on Nov.
16th, so if I could get feedback by the end of the week, I would
appreciate it.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Ginnie,
I started looking at cpio.py and noticed that the line numbers
didn't match those from the "new" transfer_cpio.py file. And,
for instance, line 169 from cpio.py is commented out while the
same line (which is 173) from transfer_cpio.py is not. Shouldn't
they be the same? I haven't checked the other files, thought I'd
ask first.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
