Hi Ginnie,
I had one further comment.
On 11/ 5/10 02:51 PM, Ginnie Wray wrote:
Hi Sue -
Thanks for the review. My responses are in line.
ginnie
On 11/05/10 15:05, Sue Sohn wrote:
On 11/ 2/10 05:58 PM, Ginnie Wray wrote:
I've incorporate the code review comments from the first round of
code reviews and would like follow up feedback. The code is posted at:
http://cr.opensolaris.org/~ginnie/transfer/
I've posted the diffs from the first code review, so I would like
to clarify: Keith suggested changing the names of the files from
transfer_*.py to just *.py, which I've done. That, however, made it
difficult to post the diffs from the original transfer_*.py files.
What I've done is included the new file names, and then also posted
the diffs from the old files. So, there is no need to review any of
the files marked as new. They are identical to the transfer_*.py file.
My thought was that it would make it a little easier to review the diffs.
Let me know if you have any questions or comments. I would like to push on Nov.
16th, so if I could get feedback by the end of the week, I would appreciate it.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
test_svr4.py
52 It looks like you started to implement my suggestion from last time to do
this in setup - but have it commented out. It does seem like an appropriate
change if it works for you.
It doesn't work. It needs to be instantiated for each test.
I did give it a try.
If done in setUp, it should be instantiating it for each test. Maybe take
another look at it? We can discuss offline if there is an issue.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
