On 11/23/10 04:06 PM, Dermot McCluskey wrote:
> Darren,
> 
> A couple of little typos I noticed in 
> usr/src/lib/install_doc/data_object/simple.py:
> 
>     46 class MyTag(SimpleXMLHanderBase):
> s/XML/Xml/

Fixed.

> 
> Also, it might be useful to show the required import statement
> with the example code, eg
>     from solaris_install.data_object.simple import SimpleXmlHandlerBase
> 

I agree, fixed this too.

> 
> 
>     83 '''Check of XML tag matches TAG_NAME'''
> s/of/if/

Fixed that...

> 
> Otherwise, LGTM.
> 

Thanks,

Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to