Darren,
A couple of little typos I noticed in
usr/src/lib/install_doc/data_object/simple.py:
46 class MyTag(SimpleXMLHanderBase):
s/XML/Xml/
Also, it might be useful to show the required import statement
with the example code, eg
from solaris_install.data_object.simple import SimpleXmlHandlerBase
83 '''Check of XML tag matches TAG_NAME'''
s/of/if/
Otherwise, LGTM.
- Dermot
On 11/23/10 15:26, Darren Kenny wrote:
Hi,
I'd like to request a code review for the simple RFE:
6999987 Need for a simple XML node base-class in the data cache
This came from the code review of DC, where it was felt that such a utility
class would be useful to be provided in the Data Object Cache.
I've implemented the class, and some tests that provide 100% coverage.
The webrev can be found at:
http://cr.opensolaris.org/~dkenny/fix.6999987.slim/
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
