Hi Darren,
I like this class (needed something like it for the SCI tool). The code
looks good to me. Conceptually, would it be worthwhile to have
"TAG_NAME" be an abc.abstractproperty, rather than asserting on it in
the __init__ method? ("No" is a perfectly reasonable answer; I'm not
sure it's worth the effort myself...)
- Keith
On 11/23/10 07:26 AM, Darren Kenny wrote:
Hi,
I'd like to request a code review for the simple RFE:
6999987 Need for a simple XML node base-class in the data cache
This came from the code review of DC, where it was felt that such a utility
class would be useful to be provided in the Data Object Cache.
I've implemented the class, and some tests that provide 100% coverage.
The webrev can be found at:
http://cr.opensolaris.org/~dkenny/fix.6999987.slim/
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
