Evan,
Thanks. I added an appropriate comment:
@@ -686,6 +686,10 @@
# caught in the service log file.
sys.stderr.write(_('warning:No such Automated Install
service '
'%s\n') % srv)
+
+ # remove the service references for the now non-existent
+ # service that was just identified. This can occur when
+ # a service is deleted.
if srv in self.sdrefs:
self._restart_loop = True
for sdref in self.sdrefs[srv]:
That explains the reason.
Thanks,
John
On 12/16/10 06:18 PM, Evan Layton wrote:
Hi John,
Just a nit...
-line 689 - It might be helpful to add a comment on why you need
to set the loop restart here and clean up the sdrefs.
I think I understand why ;) but a comment would just
be nice for when we look at this down the line.
Other than that it looks OK to me.
-evan
On 12/16/10 6:58 PM, John Fischer wrote:
All,
My link to the code review is incorrect. It should be:
http://cr.opensolaris.org/~johnfisc/7007574-aimdns
Sorry about the confusion. Thanks Evan for catching
that one.
Thanks,
John
On 12/16/10 05:37 PM, John Fischer wrote:
All,
Can I get a review for the following?
7007574 /system/install/server:default went into maintainece mode in
snv_154
The webrev is located at:
http://cr.opensolaris.org/~johnfisc/7007575-aimdns
This issue is really a stopper for AI.
The cause of the failure is that original testing by me of aimdns
showed that
looping
in browse/find modes 5 times was sufficient to find all the services.
Unfortunately,
that was sooooo wrong. The solution is to figure out how many
services are on the
system and multiple that number by how many interfaces are being
used on the
host.
Then loop that many times to allow the DNSServiceProcessResults() to
be called a
sufficient number of times.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
