On 12/16/10 08:58 PM, John Fischer wrote:
All,
My link to the code review is incorrect. It should be:
http://cr.opensolaris.org/~johnfisc/7007574-aimdns
Sorry about the confusion. Thanks Evan for catching
that one.
Thanks,
John
On 12/16/10 05:37 PM, John Fischer wrote:
All,
Can I get a review for the following?
7007574 /system/install/server:default went into maintainece mode in
snv_154
The webrev is located at:
http://cr.opensolaris.org/~johnfisc/7007575-aimdns
This issue is really a stopper for AI.
The cause of the failure is that original testing by me of aimdns
showed that looping
in browse/find modes 5 times was sufficient to find all the services.
Unfortunately,
that was sooooo wrong. The solution is to figure out how many services
are on the
system and multiple that number by how many interfaces are being used
on the host.
Then loop that many times to allow the DNSServiceProcessResults() to
be called a
sufficient number of times.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
John,
Looks good. I do have a question.
In the below code:
393 while not self._restart_loop and not self.done:
394 try:
395 # process the appropriate service reference
396 try:
397 ready = select.select(therefs, [], [],
self.timeout)
398 except select.error:
399 continue
400 if self.done:
401 continue
Are lines 400 & 401 necessary? Isn't the check on line 393 sufficient or
are you expecting the select processing to toggle self.done?
Please confirm if lines 400 & 401 are necessary.
Thank you,
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
