Ginnie,
Yes. This code is used else where which the services is needed
afterwards. However, that is not the case in this particular situation.
I'll change it as suggested.
Thanks,
John
On 12/17/10 08:58 AM, Ginnie Wray wrote:
Hi John -
one question....
at lines 793/794, couldn't you replace
services = inst.services.keys()
for service in services:
with
for service in inst.services.keys():
and get the same result?
thanks,
ginnie
On 12/16/10 18:58, John Fischer wrote:
All,
My link to the code review is incorrect. It should be:
http://cr.opensolaris.org/~johnfisc/7007574-aimdns
Sorry about the confusion. Thanks Evan for catching
that one.
Thanks,
John
On 12/16/10 05:37 PM, John Fischer wrote:
All,
Can I get a review for the following?
7007574 /system/install/server:default went into maintainece
mode in snv_154
The webrev is located at:
http://cr.opensolaris.org/~johnfisc/7007575-aimdns
This issue is really a stopper for AI.
The cause of the failure is that original testing by me of aimdns
showed that looping
in browse/find modes 5 times was sufficient to find all the
services. Unfortunately,
that was sooooo wrong. The solution is to figure out how many
services are on the
system and multiple that number by how many interfaces are being
used on the host.
Then loop that many times to allow the DNSServiceProcessResults() to
be called a
sufficient number of times.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
