On 12/13/10 07:46 PM, John Fischer wrote:
All,
Ethan found an issue with aimdns. Thanks Ethan!!
I have updated the webrev with the changes. The new webrev is at:
http://cr.opensolaris.org/~johnfisc/webserver-design/
http://cr.opensolaris.org/~johnfisc/webserver-design-diff/
http://cr.opensolaris.org/~johnfisc/webserver-design-orig/
A couple of things from a light review.
publish_manifest.py:
628-633: This should be done using Python's pwd module. A simple
pwd.getpwnam() should cover you.
cgi_get_manifest.py:
432,435: Please use "Solaris Automated Installation"
check-server-setup.sh, 251: Why shouldn't we just do this automatically?
Or, perhaps a better question: why wouldn't it exist? the manifest
for this service is part of this same package, and so should be already
imported by the time this code would ever run. (Same question probably
applies to the pre-existing blocks above this...)
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
