Dave,
Thanks. I usually do look through the docs.python.org for stuff rather then
implement something but thanks for the reminder. I'll yank the code
that checks
to see if the property exists but leaving in the validation code.
Thanks,
John
On 01/ 3/11 07:28 AM, Dave Miner wrote:
On 12/30/10 01:51 PM, Dave Miner wrote:
A couple of things from a light review.
publish_manifest.py:
628-633: This should be done using Python's pwd module. A simple
pwd.getpwnam() should cover you.
I knew someone would have a 1 liner ( pwd.getpwnam('webservd').pw_uid )
for that
part of the code. I have incorporated this change.
I highly recommend a browse/search through
http://docs.python.org/library/index.html before implementing any
basic functionality that isn't all that specific to your application.
Can save a lot of time.
I usually do look there for functionality like this.
check-server-setup.sh, 251: Why shouldn't we just do this
automatically? Or, perhaps a better question: why wouldn't it exist?
the manifest for this service is part of this same package, and so
should be already imported by the time this code would ever run.
(Same question probably applies to the pre-existing blocks above
this...)
Good question. It should be there already. I was trying to keep the
code
consistent with what was already present. I do think that it is safe to
assume
that these properties exist as you point out. The good news is that
this portion
of the code will be re-written shortly. Do you think that I need to
change it at
the present time? I would simply remove it as well as the other code
above.
I'd just remove it and its friends so we don't somehow have it hanging
around through the rewrite.
I'll yank that code.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
