On 01/13/11 10:24 PM, John Fischer wrote:
All,
I have updated the webrev to match the current discussion and
testing.
The significant change is that there is now an impact on DC.
Essentially I introduce a version file into the auto-install
common package. This version file is copied into the generated
ISO .image_file without the comments from the file. This was
needed so that we could tell if the ISO being used for a service
was old or new and act accordingly when setting up a new
service.
The new webrev is available at:
http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-4/
http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-orig-4-diff/
The webrev that tracks the differences between review round 3 and
round 4 is located at:
http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-diff-3-4/
The new version file needs comments that explain it a bit.
installadm_util.c
191: Somewhat a nit, but a predicate function such as
check_port_in_use() would be more usually named like is_port_in_use()
232: one edge case here is that, were the port passed in equal to zero
and the service port had a value that strtol() couldn't convert, you'd
end up saying 0 is in use because 0 + setting EINVAL is how strtol
handles error cases.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
