Dave,
Thanks for the review. In short, I'll add verbage to the version file
and print an error and
exit for the second issue. Do you want to see the code in another webrev?
Thanks,
John
On 01/24/11 11:56 AM, Dave Miner wrote:
My request for explanatory comments in
usr/src/cmd/auto-install/version has not been addressed.
I totally missed that comment in round 4 of the review. Sorry.
I'll add some text within the file and for the variable specifically.
ai_get_manifest.py, 612: If no version is found in the file, is 1.0
really the right thing to return? Why wouldn't we error this case?
My thinking was this is the first version of the protocol change. If
the file exists
then we are at least at version 1.0. We could:
1. return 1.0 - based upon logic above, perhaps print a warning
2. return None - passing None within the http request will cause
the server to return an
error.
3. return an error and exit
4. print an error and exit
I think that I'll print and error and exit. This should really never
happen.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
