On 01/21/11 09:20 PM, John Fischer wrote:
All,After an IRC conversation with Ethan I have made a slight modification to the webrev. I am keeping it at round 5. The modification is to the svc-install-service file. Essentially the code used to loop on the apache PIDs issuing an apacheclt stop with each iteration of the loop. It now issues the apachectl stop and then loops on the apache PIDs until they are gone or the SMF service timeout for stop is reached. The webrev is still at: http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-5/ http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-diff-5/ Thanks, John On 01/21/11 11:59 AM, John Fischer wrote:All, Here is hopefully the final webrev review for this project. http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-5/ http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-diff-5/ The changes include everything that has been discussed. Plus issues that have been found by Mary (Trouble Maker) Ding, myself during tests and the issue that Sanjay found yesterday.
My request for explanatory comments in usr/src/cmd/auto-install/version has not been addressed.
ai_get_manifest.py, 612: If no version is found in the file, is 1.0 really the right thing to return? Why wouldn't we error this case?
Dave _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
