On 01/24/11 03:23 AM, Jan Damborsky wrote:
Hi,
thank you all who provided us with valuable feedback
for the first version of System Configuration Interactive tool.
The updated webrev addressing all comments received has been published:
http://cr.opensolaris.org/~kemitche/sci.1.2/
We also wanted to publish incremental webrev and Keith spent significant
amount of time
trying to generate that. However, due to the merges with different gates
(CUD, slim_source)
we didn't find out how to create 'clean' incremental webrev. But we are
at least providing
following one:
http://cr.opensolaris.org/~kemitche/sci.1.2.diff
system_info.py, 116: this comment duplicates the one at 228; I'd remove
it so that it doesn't end up incorrect if determine_terminal_type()'s
implementation is changed.
Otherwise I'm fine with the changes made from my prior comments.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
