Hi Jan and Keith.
I've re-examined just the parts I commented on earlier. Most looks
good. Just a few comments:
profile/__init__.py:
117: I didn't think setters were supposed to return anything. Should it
raise an exception to denote an
error condition?
74: In a previous response, Keith suggested that "there was a lack of
docstrings in the ConfigProfile object. There are no newer comments in
that object, but I'm not sure that any are needed there at this
point... What do you think?
Thanks,
Jack
On 01/24/11 12:23 AM, Jan Damborsky wrote:
Hi,
thank you all who provided us with valuable feedback
for the first version of System Configuration Interactive tool.
The updated webrev addressing all comments received has been published:
http://cr.opensolaris.org/~kemitche/sci.1.2/
We also wanted to publish incremental webrev and Keith spent
significant amount of time
trying to generate that. However, due to the merges with different
gates (CUD, slim_source)
we didn't find out how to create 'clean' incremental webrev. But we
are at least providing
following one:
http://cr.opensolaris.org/~kemitche/sci.1.2.diff
This appears to be correct, with the caveat that, due to the above
issues, it "looks"
like we're re-adding old DC, and it also picks up merges from
slim_source. The diffs
in the SCI-touched files are, however, accurate. Where not sure,
please use full webrev
as the referential one.
The updated webrev in addition contains SCI unit tests and fixes
for following two bugs:
7004649 InstallLogger doesn't propagate log levels appropriately
7002621 The initial user configuration needs other entries
We would like to ask you if you could please take a look at updated
webrev and let us know if we neglected to address some comments
or if you feel anything else was missed.
Thank you very much,
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
