On 01/26/11 12:54 AM, Jack Schwartz wrote:
HI Jan.
On 01/25/11 04:37 AM, Jan Damborsky wrote:
Hi Jack,
thank you very much for review.
Please see my response in line.
Jan
On 01/24/11 10:46 PM, Jack Schwartz wrote:
Hi Jan and Keith.
I've re-examined just the parts I commented on earlier. Most looks
good. Just a few comments:
profile/__init__.py:
117: I didn't think setters were supposed to return anything.
Should it raise an exception to denote an
error condition?
From what I have just learnt about Python 'setter', its return value
seems
to be discarded so unless Keith objects, I will simplify code on
lines 116-119
in following way:
if self.system and user_infos:
self.system.users = user_infos
My only concern here is a silent failure where nothing is set and no
error is generated. Will this be a problem?
Hi Jack,
consumer of sysconfig module would hit that problem if
it didn't implement initialization phase correctly. Since that would
be caught during implementation and it would not be a runtime
issue, I think we do not need to explicitly handle that.
Along those lines, I believe that making 'users' directly attribute of
ConfigProfile
would be the right thing to do. The reason for 'users' being defined as
attribute
of 'system' for now is that 'timezone' and 'user/root configuration'
currently share the
same smf service (install/config). Once timezone configuration is moved
to smf,
we will be able to split that and separate 'users' from 'system'. I will
file bug for this.
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
