On 01/27/11 06:10 PM, Jack Schwartz wrote:
Hi guys.
On 01/27/11 01:41 AM, Jan Damborsky wrote:
On 01/26/11 05:31 PM, Keith Mitchell wrote:
On 01/25/11 03:54 PM, Jack Schwartz wrote:
HI Jan.
On 01/25/11 04:37 AM, Jan Damborsky wrote:
Hi Jack,
thank you very much for review.
Please see my response in line.
Jan
On 01/24/11 10:46 PM, Jack Schwartz wrote:
Hi Jan and Keith.
I've re-examined just the parts I commented on earlier. Most
looks good. Just a few comments:
profile/__init__.py:
117: I didn't think setters were supposed to return anything.
Should it raise an exception to denote an
error condition?
From what I have just learnt about Python 'setter', its return
value seems
to be discarded so unless Keith objects, I will simplify code on
lines 116-119
in following way:
if self.system and user_infos:
self.system.users = user_infos
My only concern here is a silent failure where nothing is set and
no error is generated. Will this be a problem?
Thanks,
Jack
Actually, the original code was probably correct, now that I think
of it. It would error in that case...
I do not have strong opinion on that, so whatever works for you guys :-)
Please let me know if I you think it would be appropriate to revert
that code
to the original form which generates error if system was not
initialized:
@users.setter
def users(self, user_infos):
if user_infos:
self.system.users = user_infos
I've laid my observations on the table, and I leave it up to you, the
experts most familiar with the code, to do the right thing.
Thank you very much for your comments, Jack.
I let Keith make the final decision, since he is the author of that code,
thus most eligible to evaluate what's compliant with the original idea.
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
