Hi Ethan.
Here are my comments.
Section 2.0:
first bullet: ... do an automated installation OF a global system...
Section 5.1.2: Is it possible to set up a sysidcfg file for an S11 zone
by mistake? If not, then no problem, but if yes, what happens?
5.1.3: Noted: there is no mention of a Derived Manifests checkpoint
here, but being that's a special case, it should be OK.
5.1.3.1.1:
- top of page 7: s/success of failure/success or failure/g
- Last PP: I don't understand how this could be a future enhancement.
How come the zonecfg zfs_report-ed data sets are not needed to carry out
the install of NGZs when the GZ is installed by AI?
5.1.4:
- Nit: 1st PP: get rid of comma before svc:/system/zones/install:default.
- 1st PP: by "mimic" do you mean "be a copy of"? If yes, saying so
would be clearer.
5.2: Nit: last sentence, 1st PP: s/expect/expected/g
Just checking: NGZs use the same boot_archive as their GZ? That's why
no boot_archive ICT checkpoint is there?
5.2.1: s/<add_driver>/<add_drivers>/g
5.2.2.1:
Nit: first bullet: s/the give base/the given base/g
Just curious: maybe this is normally how it's done, but it seems that
having separate properties for the lengths of BE_ATTR_FS_NAMES and
BE_ATTR_SHARED_FS_NAMES is redundant. Instead, can't the list be null
terminated or something?
5.2.4: Does it make sense to have a single TransferLogs checkpoint
class, which would read a list of files instead? Then if the list of
files changes, you're not changing code, but a list it reads instead.
This seems easier to maintain.
Nit: sentence between the second and third bullet:
s/transfer this files/transfer these files/g
Same sentence: it may be clearer to say "the same pathname as for the
global zone" instead of "the same location as in the global zone". This
differentiates the same pathname in two zones going to different places,
vs a shared physical location for all zones.
Thanks,
Jack
On 02/14/11 01:39 PM, Ethan Quach wrote:
All,
I have uploaded the design document for AI Zones support into the
caiman-docs gate.
http://src.opensolaris.org/source/xref/caiman/caiman-docs/AI/AI_Zones_Design.odt
General review appreciated, and if so, please try to get me comments
by the end of the week; but I have also pinged individuals to review
particular parts of the document.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
