Dave,
Sounds good. I'll make the change and push this.
-Drew
On 04/25/11 08:03, Dave Miner wrote:
On 04/22/11 03:49 PM, Drew Fisher wrote:
OK. Once more, now with xincludes!
http://cr.opensolaris.org/~drewfish/cr_7037378/
Tested by building and starting an install of AI. Everything's peachy.
If you could make the comment at 24 of lang_facets.xml a bit more
descriptive of its actual purpose, that would be good; maybe something
like: "Basic package image properties for install images". Otherwise
looks fine.
Dave
-Drew
On 4/22/11 9:25 AM, Dave Miner wrote:
On 04/22/11 11:14 AM, Drew Fisher wrote:
Good Morning!
Could I please get a code review for the following CR?
7037378<http://monaco.us.oracle.com/detail.jsf?cr=7037378> specify
locale facets in default DC manifests
http://cr.opensolaris.org/~drewfish/cr_7037378/
Fix is fine, though I would have given you extra credit if you'd done
an xinclude like boot archive contents :-)
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
