Drew:

To be safe, we should wait for Brock to push his change to the pkg5 repo. Then we need to do some DC testing with your change and make sure there are no problem before we integrate. I had sparc and x86 test machine set aside for testing this.



On 04/26/11 05:55 AM, Drew Fisher wrote:
Good morning,

Could I get a code review for 7039499 - Need to change slim_source for IPS API_VERSION change of 57 for snv_165

Just like the last CR, it's a pair of simple changes to $SRC/cmd/js2ai/modules/conv.py and $SRC/lib/install_transfer/ips.py:

Mary: Once I get a couple of approvals for this change, do you want me to push this immediately or wait for Brock to push his changes to the pkg5 repository?





[mox:install_transfer] > hg pdiffs
diff -r 82e74c7e77a6 usr/src/cmd/js2ai/modules/conv.py
--- a/usr/src/cmd/js2ai/modules/conv.py Mon Apr 25 08:47:38 2011 -0600
+++ b/usr/src/cmd/js2ai/modules/conv.py Tue Apr 26 06:52:02 2011 -0600
@@ -46,7 +46,7 @@

 # This is defined here since we can't collect this information from the
 # pkg api. This is needed to make the calls into the pkg api.
-CLIENT_API_VERSION = 55
+CLIENT_API_VERSION = 57

 # These validation patterns were taken directly from the jumpstart
 # check script
diff -r 82e74c7e77a6 usr/src/lib/install_transfer/ips.py
--- a/usr/src/lib/install_transfer/ips.py Mon Apr 25 08:47:38 2011 -0600 +++ b/usr/src/lib/install_transfer/ips.py Tue Apr 26 06:52:02 2011 -0600
@@ -106,7 +106,7 @@
     __metaclass__ = abc.ABCMeta

     # Variables associated with the package image
-    CLIENT_API_VERSION = 55
+    CLIENT_API_VERSION = 57
     DEF_REPO_URI = "http://pkg.opensolaris.org/release";
     DEF_PROG_TRACKER = progress.CommandLineProgressTracker()




Thanks!

-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to