I'll run through Brock's email and our code and make sure we're up to date on the API calls he changed. Thanks for catching all that, Ethan.

-Drew

On 4/26/11 12:56 PM, Ethan Quach wrote:
Drew,

Have you looked at the actual API changes? In looking at Brock's mail, the following looks like they'll impact us as well:

      pkg.client.api.ImageInterface has changed as follows:
         * get_preferred_publisher has been replaced with
           get_highest_ranked_publisher


install_ict/cleanup_cpio_install.py  line 311

        publisher = api_inst.get_preferred_publisher()



      pkg.client.publisher.Publisher has changed as follows:
* The repositories attribute which contained a list of Repository objects has been replaced by the repository attribute which contains a
           single Repository object.

         * The selected_repository attribute has been removed.

* A sys_pub attribute has been added which indicates whether a publisher
           is a system publisher.

* The add_repository function has been replaced with the set_repository
           function.

* The has_configuration function has been added which attempts to
           determine whether a publisher has been configured by a user.

         * The remove_repository function has had its arguments removed.

         * The set_selected_repository function has been removed



install/transfer/ips.py line 353

        repo = pub.selected_repository


install/transfer/ips.py line 379

        pub = publisher.Publisher(prefix=self._publ, repositories=repo)


install/transfer/ips.py line 401

         pub = publisher.Publisher(prefix=element, repositories=repo)



thanks,
-ethan



On 04/26/11 05:55, Drew Fisher wrote:
Good morning,

Could I get a code review for 7039499 - Need to change slim_source for IPS API_VERSION change of 57 for snv_165

Just like the last CR, it's a pair of simple changes to $SRC/cmd/js2ai/modules/conv.py and $SRC/lib/install_transfer/ips.py:

Mary: Once I get a couple of approvals for this change, do you want me to push this immediately or wait for Brock to push his changes to the pkg5 repository?





[mox:install_transfer] > hg pdiffs
diff -r 82e74c7e77a6 usr/src/cmd/js2ai/modules/conv.py
--- a/usr/src/cmd/js2ai/modules/conv.py Mon Apr 25 08:47:38 2011 -0600
+++ b/usr/src/cmd/js2ai/modules/conv.py Tue Apr 26 06:52:02 2011 -0600
@@ -46,7 +46,7 @@

 # This is defined here since we can't collect this information from the
 # pkg api. This is needed to make the calls into the pkg api.
-CLIENT_API_VERSION = 55
+CLIENT_API_VERSION = 57

 # These validation patterns were taken directly from the jumpstart
 # check script
diff -r 82e74c7e77a6 usr/src/lib/install_transfer/ips.py
--- a/usr/src/lib/install_transfer/ips.py Mon Apr 25 08:47:38 2011 -0600 +++ b/usr/src/lib/install_transfer/ips.py Tue Apr 26 06:52:02 2011 -0600
@@ -106,7 +106,7 @@
     __metaclass__ = abc.ABCMeta

     # Variables associated with the package image
-    CLIENT_API_VERSION = 55
+    CLIENT_API_VERSION = 57
     DEF_REPO_URI = "http://pkg.opensolaris.org/release";
     DEF_PROG_TRACKER = progress.CommandLineProgressTracker()




Thanks!

-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to