OK.
I changed the check in Partition.from_xml() to look like this:
# Users can specify no name for a partition (in the case of
# action=use_existing_solaris2, the user may not know the
partition ID
# of that partition.)
if name is None or len(name) == 0:
partition = Partition(None)
else:
partition = Partition(name)
Does that work for you?
-Drew
On 5/3/11 7:39 AM, Matt Keenan wrote:
One slight nit, this caters for where partition name is not specified
at all, however
I think you need to check that the name is not empty as well as not
none. e.g. in physical.py :
if self.name is not None and len(self.name) > 0:
This will cater for :
<partition name="">
Which does pass manifest parser validation.
cheers
Matt
On 05/ 3/11 02:32 PM, Drew Fisher wrote:
Good morning!
Could I please get a code review for the following CR:
7041296 <http://monaco.us.oracle.com/detail.jsf?cr=7041296>
install/targets int() argument must be a string or a number, not
'NoneType'
http://cr.opensolaris.org/~drewfish/cr_7041296/
The two files where no changes show up in the webrev are nothing more
than white space changes. All unittests run completely.
I also ran pep8 and pylint on the files. Everything comes back clean.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
