Thanks Matt!
-Drew
On 5/3/11 8:58 AM, Matt Keenan wrote:
Reloaded webrev looks good.
cheers
Matt
On 05/ 3/11 03:05 PM, Drew Fisher wrote:
On 5/3/11 8:03 AM, Dermot McCluskey wrote:
Drew,
In physical.py, why change:
121 partition = Partition(name)
to
125 if name is not None:
126 partition = Partition(name)
127 else:
128 partition = Partition(None)
Does that not do exactly the same thing (ie call
Partition() with a param of None, if name is None)?
- Deermot
Ha. That'll teach me to do code changes before I've had coffee. :)
I do need to put a trap in for an empty string as Matt pointed out but
otherwise I'll just pass the value through.
Also, it looks like you need coffee too ;)
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
