Drew, In physical.py, why change:
121 partition = Partition(name) to 125 if name is not None: 126 partition = Partition(name) 127 else: 128 partition = Partition(None) Does that not do exactly the same thing (ie call Partition() with a param of None, if name is None)? - Deermot On 05/03/11 14:32, Drew Fisher wrote:
Good morning! Could I please get a code review for the following CR: 7041296 <http://monaco.us.oracle.com/detail.jsf?cr=7041296> install/targets int() argument must be a string or a number, not 'NoneType' http://cr.opensolaris.org/~drewfish/cr_7041296/ The two files where no changes show up in the webrev are nothing more than white space changes. All unittests run completely. I also ran pep8 and pylint on the files. Everything comes back clean. Thanks! -Drew _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
