Hey Drew, * Drew Fisher ([email protected]) wrote: > Good afternoon! > > Could I please get a code review for the following two bugs: > > 7044170 <http://monaco.us.oracle.com/detail.jsf?cr=7044170> AI > should support "s" for sector units > 7044383 <http://monaco.us.oracle.com/detail.jsf?cr=7044383> Zvol > deletion should cater for swap/dump deletion > > http://cr.opensolaris.org/~drewfish/cr_7044383/
Just a general comment about 7044383. What are we gaining by allowing the removal of the dump zvol if we can't simultaneously remove it from the dumpadm config? We're essentially 'breaking' dumpadm. We'll also need to revisit 'allow deletion of dump zvols' when (really, if considering it's state) 6910925 is addressed to complete the changes (and so I wonder if we might just want to hold off on allowing dump zvols to be destroyed until we really can do support that operation fully). Cheers, -- Glenn _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
