On 05/12/11 11:31 PM, Glenn Lagasse wrote:
Hey Drew,
* Drew Fisher ([email protected]) wrote:
Good afternoon!
Could I please get a code review for the following two bugs:
7044170<http://monaco.us.oracle.com/detail.jsf?cr=7044170> AI
should support "s" for sector units
7044383<http://monaco.us.oracle.com/detail.jsf?cr=7044383> Zvol
deletion should cater for swap/dump deletion
http://cr.opensolaris.org/~drewfish/cr_7044383/
Just a general comment about 7044383. What are we gaining by allowing
the removal of the dump zvol if we can't simultaneously remove it from
the dumpadm config? We're essentially 'breaking' dumpadm. We'll also
need to revisit 'allow deletion of dump zvols' when (really, if
considering it's state) 6910925 is addressed to complete the changes
(and so I wonder if we might just want to hold off on allowing dump
zvols to be destroyed until we really can do support that operation
fully).
Drew,
Comment in logical.py :
"(although we can destroy the zvol)"
This is not true, because we cannot unassign the zvol as a dump device,
the zvol itself cannot be destroyed, and therefore the pool cannot be
destroyed either, so I reckon best to remove this portion of the comment.
Glenn, we discussed this in detail with Drew, and CUD AI will trap on
this scenario if a manifest is specifying to remove a dump zvol device,
and put appropriate information to the log stating how to work around
this. Essentially we are not allowing it, until 6910925 is addressed.
cheers
Matt
Cheers,
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
