Hi William,
Just a couple of nits (no need to see another webrev):
network_nic_configure.py
52 "for the this" -> "for this"
nameservice.py
118 Output needs period at end of sentence instead of space
Sue
On 05/18/11 06:23 AM, William Schumann wrote:
Sue,
Thanks for the review. Took all recommendations, unless noted below.
Updated webrev at http://cr.opensolaris.org/~wmsch/bug-7031613-1/
Differences at http://cr.opensolaris.org/~wmsch/bug-7031613-1diff
Also did some unrelated cleanup per pep8 on profile/__init__.py.
On 05/16/11 08:31 PM, Sue Sohn wrote:
On 05/12/11 04:33 AM, William Schumann wrote:
Reinstating request for code review for adding Name Services to SCI Tool
http://cr.opensolaris.org/~wmsch/bug-7031613/
...
...
ns_info.py
...
225 Define static dict propdict somewhere else
1) Strictly speaking, there is no notion of 'static' in Python.
2) Why? On what grounds?
summary.py
161,162,164,166, and others Should the text being output have spaces in front
of it, ala 157 and 159?
One would think so, but for some reason, the spaces do not appear on the screen,
providing the desired indentation.
Thanks,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
