On Thu, Jun 23, 2011 at 9:10 AM, Jack Schwartz <[email protected]>wrote:
> Hi Karen. > > Based on the bug report, the code changes seem reasonable to me. (I assume > _show() is called by a framework somewhere when it is time to show the > screen, after all data gathering is completed.) > Correct - the parent class, BaseScreen, handles that. (I think in this case, self.wait_for_disks() handles delaying the completion of _show() until TD completes). - Keith > > I suggest changing the comments on 230-232, as: > 1) the _td_callback() now only changes the target discovery status > 2) find reveals no _display_disks() function in slim_source. > > Thanks, > Jack > > > > > On 06/22/11 12:36 PM, Karen Tung wrote: > >> I would like to get a review for changes to fix the following bug: >> >> 7052228 BadDiskError is never caught >> http://monaco.us.oracle.com/**detail.jsf?cr=7052228<http://monaco.us.oracle.com/detail.jsf?cr=7052228> >> >> webrev: >> >> http://cr.opensolaris.org/~**ktung/7052228/<http://cr.opensolaris.org/%7Ektung/7052228/> >> >> I have tested the changes by verifying that when there's no disk on the >> system at all, no exception is thrown, and the text installer displays >> a message about not being able to find any disks. I also verified that >> the >> change didn't cause any regression. >> >> Thanks, >> >> --Karen >> ______________________________**_________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/**mailman/listinfo/caiman-**discuss<http://mail.opensolaris.org/mailman/listinfo/caiman-discuss> >> > > ______________________________**_________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/**mailman/listinfo/caiman-**discuss<http://mail.opensolaris.org/mailman/listinfo/caiman-discuss> > -- Join me in the fight to end AIDS! http://www.tofighthiv.org/goto/kemitche
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
