On 06/23/11 10:12, Sue Sohn wrote:
Hi Karen,

Just a question - if a user traverses forward and then back to that screen (possibly multiple times), will that extra processing be done each time and is that something you want?

Sue
Hi Sue,

Good catch. If a user goes back and forth to the screen, there's no protection against recomputing the image size and re-initializing the target controller. Even though doing the extra processing does not hurt, it is a waste of time. I added a private variable to track whether tc.initialize() is called or not.

The webrev is updated in place with my changes:

http://cr.opensolaris.org/~ktung/7052228/

Thanks,

--Karen



On 06/22/11 12:36 PM, Karen Tung wrote:
I would like to get a review for changes to fix the following bug:

7052228 BadDiskError is never caught
http://monaco.us.oracle.com/detail.jsf?cr=7052228

webrev:

http://cr.opensolaris.org/~ktung/7052228/

I have tested the changes by verifying that when there's no disk on the
system at all, no exception is thrown, and the text installer displays
a message about not being able to find any disks. I also verified that the
change didn't cause any regression.

Thanks,

--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to