Thanks, Karen.
LGTM.
Jack
On 06/23/11 03:09 PM, Karen Tung wrote:
Hi Jack,
Thank you for your code review. Please see my response inline.
On 06/23/11 09:10, Jack Schwartz wrote:
Hi Karen.
Based on the bug report, the code changes seem reasonable to me. (I
assume _show() is called by a framework somewhere when it is time to
show the screen, after all data gathering is completed.)
I suggest changing the comments on 230-232, as:
1) the _td_callback() now only changes the target discovery status
2) find reveals no _display_disks() function in slim_source.
The comments to the _td_callback() function is updated. The
_display_disks() function
was in the pre-CUD code. I guess I didn't update the comment in that
putback.
I updated the webrev in place, and retested:
http://cr.opensolaris.org/~ktung/7052228/
Please let me know if you have any other comments.
Thanks,
--Karen
Thanks,
Jack
On 06/22/11 12:36 PM, Karen Tung wrote:
I would like to get a review for changes to fix the following bug:
7052228 BadDiskError is never caught
http://monaco.us.oracle.com/detail.jsf?cr=7052228
webrev:
http://cr.opensolaris.org/~ktung/7052228/
I have tested the changes by verifying that when there's no disk on the
system at all, no exception is thrown, and the text installer displays
a message about not being able to find any disks. I also verified
that the
change didn't cause any regression.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
