Matt,
varshared.py:
Do any 'raise exception' messages need to be localized?
78: will get_descendants method always return a list with at least one element?
125, 129: 'as could not' not clear to me. Should Filesystem be capitalized here?
155 "non root pool" -> "non-root pool"
PEP8 states that blank lines should be used sparsely, but that doesn't seem to
be the norm for the install consolidation anyhow...
William
On 07/ 7/11 04:31 PM, Matt Keenan wrote:
Hi,
Can I get a code review for bugs :
7048015 Automated Installer should create a separate /var and shared area
7049157 Text installer should create a separate /var and shared area
7049160 GUI installer should create a separate /var and shared area
http://monaco.sfbay.sun.com/detail.jsf?cr=7048015
Webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160
All three installers need to create /var within the installed BE and /var/shared globally available. This is achieved by adding
two Filesystem objects to the DESIRED root Zpool object before Target Instantiation is called. TI will then simply create them.
A new checkpoint "VarSharedDataset" is being created to handle the additions,
and will be called by all three installers.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
